Update payload integration test to escape invalid characters #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
filmaj
approved these changes
May 31, 2023
PhuongTMR
pushed a commit
to PhuongTMR/slack-github-action
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With testing #205, in the PR #206 to make sure the integration tests run, it was determined that the
toJSON()in the payload integration test doesn't seem to work to parse the body of a given PR if it contains characters that need to be escaped within a string (example error output can be found in this test run).However, there is a workaround for this in which bash automatically escapes invalid characters in env variables (see this issue for more info). This PR adds in this workaround so that all future PRs will successfully parse as JSON, regardless of the contents of the PR description. After adding this testing update in the test integration PR, the payload integration test ran successfully.
Requirements (place an
xin each[ ])